Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: min/max voltage settings to guesstimate battery charge remaining runtime - promote runtimecal as one common solution/pattern #2420

Open
jimklimov opened this issue Apr 27, 2024 · 0 comments
Labels
enhancement impacts-release-2.8.2 Issues reported against NUT release 2.8.2 (maybe vanilla or with minor packaging tweaks) portability We want NUT to build and run everywhere possible refactor/fightwarn PR or issue proposal to improve code maintainability without functional changes, or to fix warnings
Milestone

Comments

@jimklimov
Copy link
Member

Drivers like tripplite_usb have their own settings (e.g. 10% and 100% voltages) that would map well into runtimecal of other drivers.
Likewise, introduction of localcalculation with #1692 into riello drivers originally dealt with the idea that runtimecal should replace it.

Probably similar values appear in other drivers (these ones popped up during work on #2294).

@jimklimov jimklimov added enhancement refactor/fightwarn PR or issue proposal to improve code maintainability without functional changes, or to fix warnings portability We want NUT to build and run everywhere possible labels Apr 27, 2024
@jimklimov jimklimov added this to the NUT 2.9 milestone Apr 27, 2024
@jimklimov jimklimov added the impacts-release-2.8.2 Issues reported against NUT release 2.8.2 (maybe vanilla or with minor packaging tweaks) label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement impacts-release-2.8.2 Issues reported against NUT release 2.8.2 (maybe vanilla or with minor packaging tweaks) portability We want NUT to build and run everywhere possible refactor/fightwarn PR or issue proposal to improve code maintainability without functional changes, or to fix warnings
Projects
None yet
Development

No branches or pull requests

1 participant