-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAC Address Extension - Project Status? #254
Comments
Hey @pboulos, that's an interesting feature, I think it'd be cool having it.
Depends on time and if there's something to do maintenance-wise (important bugs etc. will get my attention but the rest not necessarily). Mostly it just works. |
I'm not saying it'd be good to go as-is (I haven't looked that closely at the PR in your fork) but the features seem useful – I can take a closer look. |
It would be great if you could take a closer look @jstasiak! Please let me know if you have any questions about the implementation - happy to assist in getting this into the package. |
I just another look at this, very nice work. I'd be keen on merging this in some form but because of the type hint coverage it'll have to wait until netaddr has dropped Python 2.7 support (should happen relatively soon). That said, the fact that there are type hints in there will certainly save me a lot of work as I'd be adding them anyway! |
Appreciate the praise! Yes, all of our internal code is type-hinted so it made sense to write this to the same standard. I will look out for when Python 2.7 support is dropped; let me know if there's anything I can do to make merging this easier. |
Hello everyone,
At my company Kepler we use functionality provided by netaddr in an application named NetBox. Recently, we've had need to extend the functionality of netaddr with regards to MAC addresses.
Specifically, we have added the below classes:
You can see the changes in a forked version of the library in this sample PR (kepler-space#1).
Is this project being actively maintained? I know the
ipaddress
module in the standard library overlaps withhnetaddr
in terms of functionality, and as suchnetaddr
hasn't been maintained as actively.What are your thoughts @jstasiak @drkjam? Tagging you both because you were involved last time when it was raised whether this library would be maintained.
The text was updated successfully, but these errors were encountered: