Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAC Address Extension - Project Status? #254

Open
pboulos opened this issue May 17, 2023 · 5 comments
Open

MAC Address Extension - Project Status? #254

pboulos opened this issue May 17, 2023 · 5 comments

Comments

@pboulos
Copy link

pboulos commented May 17, 2023

Hello everyone,

At my company Kepler we use functionality provided by netaddr in an application named NetBox. Recently, we've had need to extend the functionality of netaddr with regards to MAC addresses.

Specifically, we have added the below classes:

  • EUISet (a set of EUI addresses).
  • EUIRange (a range of EUIs with an upper and lower bound)
  • EUIPrefix (a prefix such as 0A:B9:2C:FG:E that represents a collection of EUIs)

You can see the changes in a forked version of the library in this sample PR (kepler-space#1).

Is this project being actively maintained? I know the ipaddress module in the standard library overlaps withh netaddr in terms of functionality, and as such netaddr hasn't been maintained as actively.

What are your thoughts @jstasiak @drkjam? Tagging you both because you were involved last time when it was raised whether this library would be maintained.

@jstasiak
Copy link
Contributor

Hey @pboulos, that's an interesting feature, I think it'd be cool having it.

Is this project being actively maintained?

Depends on time and if there's something to do maintenance-wise (important bugs etc. will get my attention but the rest not necessarily). Mostly it just works.

@jstasiak
Copy link
Contributor

I'm not saying it'd be good to go as-is (I haven't looked that closely at the PR in your fork) but the features seem useful – I can take a closer look.

@pboulos
Copy link
Author

pboulos commented Sep 15, 2023

It would be great if you could take a closer look @jstasiak! Please let me know if you have any questions about the implementation - happy to assist in getting this into the package.

@jstasiak
Copy link
Contributor

I just another look at this, very nice work.

I'd be keen on merging this in some form but because of the type hint coverage it'll have to wait until netaddr has dropped Python 2.7 support (should happen relatively soon).

That said, the fact that there are type hints in there will certainly save me a lot of work as I'd be adding them anyway!

@pboulos
Copy link
Author

pboulos commented Dec 27, 2023

Appreciate the praise! Yes, all of our internal code is type-hinted so it made sense to write this to the same standard.

I will look out for when Python 2.7 support is dropped; let me know if there's anything I can do to make merging this easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants