Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torch Impl project_pix does not use eps #169

Closed
mathijshenquet opened this issue Apr 27, 2024 · 2 comments
Closed

Torch Impl project_pix does not use eps #169

mathijshenquet opened this issue Apr 27, 2024 · 2 comments

Comments

@mathijshenquet
Copy link

def project_pix(fxfy, p_view, center, eps=1e-6):
-    rw = 1.0 / (p_view[..., 2] + 1e-6)
+    rw = 1.0 / (p_view[..., 2] + eps)

On this line

rw = 1.0 / (p_view[..., 2] + 1e-6)

@jb-ye
Copy link
Collaborator

jb-ye commented May 2, 2024

Oh, right. Could you send a quick fix for it?

@liruilong940607
Copy link
Collaborator

Close as the fix is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants