Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLEIGS linsolver cache double functionality #199

Open
jarlebring opened this issue Aug 20, 2019 · 0 comments
Open

NLEIGS linsolver cache double functionality #199

jarlebring opened this issue Aug 20, 2019 · 0 comments

Comments

@jarlebring
Copy link
Member

jarlebring commented Aug 20, 2019 •
edited

NLEIGS uses a cache to store factorization objects, e.g., in the code in src/rk_helper/linsolvercache.jl. In NewLinSolvers.jl the FactorizeLinSolverCreator provides the same functionality.

Therefore, I propose we remove the functionality in nleigs and base it on FactorizeLinSolver.

This has to be done carefully so we don't loose performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jarlebring