Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG 9.0 NodeMove should respect aggregate: true #3587

Open
mhsdesign opened this issue Aug 2, 2023 · 2 comments · May be fixed by #3764
Open

BUG 9.0 NodeMove should respect aggregate: true #3587

mhsdesign opened this issue Aug 2, 2023 · 2 comments · May be fixed by #3764
Assignees
@nezaniel
Labels
9.0

Comments

@mhsdesign
Copy link
Member

see

neos-ui/Classes/Domain/Model/Changes/MoveInto.php

Line 90 in 5d69c44

RelationDistributionStrategy::STRATEGY_GATHER_ALL 

$nodeType->isAggregate()
    ? RelationDistributionStrategy::STRATEGY_SCATTER
    : RelationDistributionStrategy::STRATEGY_GATHER_ALL

Related to neos/neos-development-collection#3340

basically currenlty everything is aggregate ^^

Description

[Description of the bug or feature]

Steps to Reproduce

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Expected behavior

[What you expected to happen]

Actual behavior

[What actually happened]

Affected Versions

Neos:

UI:

You can get this information by running composer show or using the package management module within Neos.
The UI version can also be found inside the left sidebar after version 1.0.3.
@Sebobo Sebobo changed the title BUGFIX: NodeMove should respect aggregate: true BUG: NodeMove should respect aggregate: true Aug 3, 2023
@mhsdesign mhsdesign changed the title BUG: NodeMove should respect aggregate: true BUG 9.0 NodeMove should respect aggregate: true Aug 7, 2023
@mhsdesign
Copy link
Member Author

To avoid having to write test for this behaviour in the neos ui we could introduce a RelationDistributionStrategy::STRATEGY_DEFAULT enum on cr basis so it could determine the respective strategy by SCATTER or GATHER_ALL and it falls back to the node type. Possibly its also better to avoid using isAggregate and to introduce a new schema option:

My:NodeType:
   relationDistributionStrategy: STRATEGY_GATHER_ALL

@ahaeslich
Copy link
Member

Possibly could be moved to 9.1

@nezaniel nezaniel linked a pull request Apr 16, 2024 that will close this issue
Draft
@mhsdesign mhsdesign mentioned this issue Apr 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nezaniel nezaniel

Labels
9.0
Projects
Neos 9.0
Status: Under Review 👀
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delegate selection of relation distribution strategy neos/neos-ui
3 participants
@nezaniel @ahaeslich @mhsdesign