Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: reference editor createNew only handles hardcoded title property but not custom one #3730

Open
mhsdesign opened this issue Mar 2, 2024 · 0 comments
Labels
9.0 Bug Label to mark the change as bugfix

Comments

@mhsdesign
Copy link
Member

As seen here in the code

const titleProperty = this.props.options.createNew.titleProperty || 'title';
or shown by this issue #1764

the createNew option allows to redirect the entered title in a custom property field if titleProperty: 'myTitle' is used. But with the introduction of the node creation handlers, https://github.com/neos/neos-ui/pull/422/ not all data/elements were saved as node properties. Currently only showInCreationDialog: true(promoted properties) or thetitle` property is automagically saved.

See pr #2563 where we hardcoded the actual default value of titleProperty.

We should instead, if we want to support the feature, transmit

createNewData:
  titleProperty: title
  value: fhiewofiewnfoewjf
mhsdesign added a commit that referenced this issue Mar 12, 2024
…ntNodeCreationHandler`

Normally due to the `showInCreationDialog` property the `PromotedElementsCreationHandler` will handle this already.

Also, the references editor with `createNew` will leverage this silently but with #3730 this has to be refactored either way
@grebaldi grebaldi added Bug Label to mark the change as bugfix 9.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0 Bug Label to mark the change as bugfix
Projects
None yet
Development

No branches or pull requests

2 participants