Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Enable table captions in CKEditor #3727

Open
so-grimm opened this issue Mar 1, 2024 · 2 comments
Open

FEATURE: Enable table captions in CKEditor #3727

so-grimm opened this issue Mar 1, 2024 · 2 comments
Labels
9.0 Feature Label to mark the change as feature

Comments

@so-grimm
Copy link

so-grimm commented Mar 1, 2024

Description

The formatting options for the inline editor (Neos.Neos:Editable) offer an option for adding tables. Adding a table creates a <figure> tag. With the way this is currently set up, it is not possible to add a <figcaption> inside the <figure>.
However, the CKEditor does provide a feature for table captions, which is not yet integrated in Neos. It would be great to add this feature.
https://ckeditor.com/docs/ckeditor5/latest/features/tables/tables-caption.html

Steps to Reproduce

  1. Add a text module which has set editorOptions: { formatting: { table: true } }
  2. Add a table

Expected behavior

Once a table is added and the new buttons for the table appear in the toolbar, there should be another button for adding a table caption. The table caption is inline editable.

Actual behavior

No table caption can be added.

[What actually happened]

Affected Versions

Neos: 8.3

UI: 8.4

@ahaeslich ahaeslich added 8.4 Feature Label to mark the change as feature labels Mar 1, 2024
@73nici
Copy link
Collaborator

73nici commented Mar 11, 2024

I would like to help with this feature :).

@mhsdesign mhsdesign added 9.0 and removed 8.4 labels Mar 13, 2024
@73nici
Copy link
Collaborator

73nici commented Mar 13, 2024

Currently version 16 is used in Neos.Ui, but table captions are possible with minimum version 28. A CKEditor5 update is therefore required.

https://github.com/ckeditor/ckeditor5/releases/tag/v28.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0 Feature Label to mark the change as feature
Projects
None yet
Development

No branches or pull requests

4 participants