Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assets in node properties are serialised in backend communication leading to slow requests and timeouts #5006

Open
Sebobo opened this issue Apr 23, 2024 · 4 comments
Open

Assets in node properties are serialised in backend communication leading to slow requests and timeouts #5006

Sebobo opened this issue Apr 23, 2024 · 4 comments
Assignees
@Sebobo
Labels
8.3 Bug

Comments

@Sebobo
Copy link
Member

Sebobo commented Apr 23, 2024 •
edited

The Neos.Neos.userInterface.inspector.dataTypes settings in

neos-development-collection/Neos.Neos/Configuration/Settings.yaml

Line 197 in 6841c68

Neos\Media\Domain\Model\Asset:
are missing configurations for other asset types than image. The Asset default configuration is not inherited by the subclasses.

Current behaviour:

  1. Have a nodetype with a non image asset property like a video
  2. Upload video with 100MB
  3. The preview html now contains 100MB of serialised video in the node script tag

Same for xhr request from the Neos UI that retrieve node properties

Expected behaviour:

Only the asset identity and type should be generated for the UI to consume.
@Sebobo Sebobo self-assigned this Apr 23, 2024
@kdambekalns
Copy link
Member

But should a video not be an Asset? Or does this happen with entirely custom types? I quickly tried this on a Neos 7.3 site that has a lot of videos, and the data loaded was reasonably small in all cases. 🤔

Sebobo added a commit that referenced this issue Apr 23, 2024
@Sebobo
BUGFIX: Add missing type converts for asset subtypes
fbc6ea9 
This prevents the raw data from being base64 encoded into the
rendered output of the Neos backend and included in
xhr requests from the Neos UI.

Additionally the default settings for editor and constraints makes the usage of those affected types easier in nodetype properties.

Resolves: #5006
@Sebobo Sebobo mentioned this issue Apr 23, 2024
Merged
@kdambekalns
Copy link
Member

Ah, no inheritance at that point! 🙈

@Sebobo
Copy link
Member Author

Sebobo commented Apr 23, 2024

But should a video not be an Asset? Or does this happen with entirely custom types? I quickly tried this on a Neos 7.3 site that has a lot of videos, and the data loaded was reasonably small in all cases. 🤔

Do you have a different configuration than the example in my PR?
Would be interesting if this either was no problem in 7.3 or depends on some other configuration.

I already wondered why nobody noticed this yet.

@Sebobo
Copy link
Member Author

Sebobo commented Apr 23, 2024

Just tested in 7.3 and it behaves the same. The size of the asset is added to the preview document.

mhsdesign pushed a commit to mhsdesign/neos-development-collection that referenced this issue May 12, 2024
@Sebobo @mhsdesign
BUGFIX: Add missing type converts for asset subtypes
fded8dd 
This prevents the raw data from being base64 encoded into the
rendered output of the Neos backend and included in
xhr requests from the Neos UI.

Additionally the default settings for editor and constraints makes the usage of those affected types easier in nodetype properties.

Resolves: neos#5006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sebobo Sebobo

Labels
8.3 Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kdambekalns @Sebobo