Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspaceName to relevant events #4996

Open
bwaidelich opened this issue Apr 18, 2024 · 0 comments · May be fixed by #5002
Open

Add workspaceName to relevant events #4996

bwaidelich opened this issue Apr 18, 2024 · 0 comments · May be fixed by #5002
Labels

Comments

@bwaidelich
Copy link
Member

bwaidelich commented Apr 18, 2024

With #4694 we made an important step towards internalizing the concept of content streams.
But so far, in the events we only include the resolved contentStreamId.

As a result, projections and catchUpHooks have to keep track/load the corresponding workspace.
Instead we should include the workspaceName in the corresponding event payloads, not to lose the information about that original intend

Notes

  • Obviously this will require another infamous event migration
    • We'll might have to decide how to deal with CS ids that are no longer resolvable to a workspace name
  • I assume that all events implementing EmbedsContentStreamAndNodeAggregateId are affected, so maybe it makes sense to extend (and rename) that interface
    • But maybe there are more events affected (e.g. there is DimensionShineThroughWasAdded and DimensionSpacePointWasMoved) so an new interface might be required
  • Afterwards, affected Neos projections (e.g. ChangeProjection and UriPathProjection) should be simplified such that they no longer keep track of the workspace

Related: #4694

@bwaidelich bwaidelich added the 9.0 label Apr 18, 2024
@grebaldi grebaldi changed the title Add workspaceName to relevant Add workspaceName to relevant events Apr 18, 2024
@bwaidelich bwaidelich linked a pull request Apr 19, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Prioritized 🔥
Development

Successfully merging a pull request may close this issue.

1 participant