Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Fix the check for RedirectStorageInterface #5001

Merged
merged 1 commit into from Apr 19, 2024
Merged

BUGFIX: Fix the check for RedirectStorageInterface #5001

merged 1 commit into from Apr 19, 2024

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Apr 19, 2024

Existance of interfaces needs to be checked with interface_exists

Fixes #5000

@dlubitz dlubitz requested a review from mhsdesign April 19, 2024 08:56
mhsdesign
mhsdesign approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups thx :)

@dlubitz dlubitz linked an issue Apr 19, 2024 that may be closed by this pull request
BUG: Redirect for changed media assets don't get created anymore #5000
Closed
1 task
bwaidelich
bwaidelich approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@dlubitz dlubitz merged commit 89aa2b4 into 8.3 Apr 19, 2024
8 checks passed
@dlubitz dlubitz deleted the bugfix-media-redirect branch April 19, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaidelich bwaidelich bwaidelich approved these changes

@mhsdesign mhsdesign mhsdesign approved these changes

Assignees
No one assigned
Labels
8.3 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Redirect for changed media assets don't get created anymore
3 participants
@dlubitz @bwaidelich @mhsdesign