Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Make it more obvious which value objects are persistent (part of the events) #4977

Open
mhsdesign opened this issue Apr 4, 2024 · 1 comment
Labels

Comments

@mhsdesign
Copy link
Member

... also the persistent parts should probably reside in SharedModel or Common as discussed with @nezaniel #4961 (comment)

The thing im trying to address here is that one never knows if this dto is part of events and should better not be touched, and if so it has to be backwards compatible. I have no solution for that yet but ill keep this ticket as reminder.

For example when writing the unset migration, i noticed by accident that i would have to adjust the metadata.commandPayload.nodeTreeToInsert.childNodes[0].childNodes[0].propertyValues.myProperty which was really intransparent ^^
Also the fact the commands are serialised into the events metadata adds complexity as this could mean that a rebase / publish can become impossible if we change something.

@mhsdesign
Copy link
Member Author

We should discuss when to use SharedModel vs Feature/Common

@ahaeslich ahaeslich added the 9.0 label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants