Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0 Should _hidden.defaultValue = true work? #4484

Open
mhsdesign opened this issue Sep 4, 2023 · 7 comments
Open

9.0 Should _hidden.defaultValue = true work? #4484

mhsdesign opened this issue Sep 4, 2023 · 7 comments
Labels

Comments

@mhsdesign
Copy link
Member

properties:
    _hidden:
      defaultValue: true

this seems to work in 8.3 (someone in slack tried it)

related #4208

@mhsdesign mhsdesign added the 9.0 label Sep 4, 2023
@Nikdro
Copy link
Contributor

Nikdro commented Sep 4, 2023

If it's not the desired way and will be removed: We should keep some kind of functionality, to configure the defaultValue for hidden :)

@kdambekalns
Copy link
Member

Accessing those by prefixing with _ has always worked, is used throughout the core and has explicit support in the code.

@mhsdesign
Copy link
Member Author

well but hidden is not a setter anymore in neos 9 - thats why it worked before

@kdambekalns
Copy link
Member

Well, but were all places using that adjusted? Even if so, do other similar properties still work? Any YAML out there using this would break…

@bwaidelich
Copy link
Member

Just to avoid confusion: Does this still work with Neos 9 (currently) via some Neos UI magic?
If so, we should keep support until we have a proper alternative
If not, anyone is free to re-implement it – but it's probably too late for a 1st beta

@mhsdesign mhsdesign mentioned this issue Sep 22, 2023
6 tasks
@mhsdesign
Copy link
Member Author

this is also related to #4550 as we could introduce a generic yaml option for default subtree tags on a node:

MyNode:
  subtreeTags:
    disabled: true

@mhsdesign
Copy link
Member Author

we could make this a NodeTemplates feature (again) see pr

'Flowpack.NodeTemplates:Content.Hidden':
   superTypes:
     'Neos.Neos:Content': true
   options:
     template:
       disabled: true

As i stated in the cr weekly: I dont think we need out of the box support for this right away for neos 9.

And with #4821 it either way wont be possible to disable tethered nodes (for integrity).

@mhsdesign mhsdesign added 9.1 and removed 9.0 labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants