Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0 FEATURE: Dynamic placeholders in Neos.Neos:Editable #4430

Closed
1 task done
crydotsnake opened this issue Aug 1, 2023 · 2 comments
Closed
1 task done

9.0 FEATURE: Dynamic placeholders in Neos.Neos:Editable #4430

crydotsnake opened this issue Aug 1, 2023 · 2 comments

Comments

@crydotsnake
Copy link
Member

crydotsnake commented Aug 1, 2023

Is there an existing issue for this topic?

  • I have searched the existing issues

Description

Description

The idea came up in a blog post from @jonnitto and i quite liked the idea.

Currently its possible to set a placeholder via the NodeType configuration when InlineEditable is set too true.

But what is when i would like to output the title of a document for example? Like in the example from the blog post it could look like:

headline = Neos.Neos:Editable {
    property = 'headline'
    block = false
    fallback = ${q(node).property('title')}
}

And then the fallback will be rendered in the frontend.

Important to know

But if I now set a fallback in my fusion component, it should check if a placeholder is already set in the NodeType (ui.inspector.editorOptions.placeholder). Then we should decide whether the fallback in the fusion part or the placeholder part in the NodeType should be output. However, the placeholder in the NodeType is ONLY displayed in the backend and not in the frontend. Therefore, I would rather tend to use the fallback in the Fusion part.

I believe the check for that would be part of the Neos UI ?

Possible Solution

No response

@crydotsnake crydotsnake changed the title FEATURE: Dynamic placeholders in Neos.Neos:Editable 9.0 FEATURE: Dynamic placeholders in Neos.Neos:Editable Aug 1, 2023
@mhsdesign
Copy link
Member

Hmm. I think we need to think about where we want to define how the editor works. For example the block option is made in fusion but other settings, like which formatting is in yaml. The placeholder can currently also be only set via yaml and im not sure how we can improve this total situation. I dont dislike this idea i just think before doing something like this we need a complete well sounding concept of where which is declared.

See also i have a similar issue with the autoparagaph false thingy: neos/neos-ui#3545

@crydotsnake
Copy link
Member Author

Hmm. I think we need to think about where we want to define how the editor works. For example the block option is made in fusion but other settings, like which formatting is in yaml. The placeholder can currently also be only set via yaml and im not sure how we can improve this total situation. I dont dislike this idea i just think before doing something like this we need a complete well sounding concept of where which is declared.

See also i have a similar issue with the autoparagaph false thingy: neos/neos-ui#3545

Hm. We could check, if a placeholder is set via the UI, or a fallback via the fusion. And then decide which case we will output.

@crydotsnake crydotsnake reopened this Nov 13, 2023
@crydotsnake crydotsnake closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants