BUG: NodeType $fullConfiguration is accessed when nodeType is not initialized.

[mhsdesign]

The NodeType (in 9.0) Has a TODO at the top

TODO: REFACTOR TO immutable readonly; and value objects

and that is pretty valid, as currently the nodeType is mutable and lazyloads its configuration.

This is problematic, in cases when we forget to call $this->initialize() before accessing $this->fullConfiguration.

I encountered this problem while testing, in my case getPropertyType didnt return the expected result.

neos-development-collection/Neos.ContentRepository/Classes/Domain/Model/NodeType.php

Lines 436 to 442 in b217795

	public function getPropertyType($propertyName)
	{
	if (!isset($this->fullConfiguration['properties']) || !isset($this->fullConfiguration['properties'][$propertyName]) || !isset($this->fullConfiguration['properties'][$propertyName]['type'])) {
	return 'string';
	}
	return $this->fullConfiguration['properties'][$propertyName]['type'];
	}

doesnt initialize the nodetype ... but other methods trigger this sideeffect correctly like getProperties

neos-development-collection/Neos.ContentRepository/Classes/Domain/Model/NodeType.php

Lines 424 to 428 in b217795

	public function getProperties()
	{
	$this->initialize();
	return (isset($this->fullConfiguration['properties']) ? $this->fullConfiguration['properties'] : []);
	}

A workaround is to call getFullConfiguration() before getPropertyType to initialize.

Other affected methods are fx. getTypeOfAutoCreatedChildNode

Affected Versions:

7.3 ... 9.0

[mhsdesign]

WOW https://github.com/neos/neos-ui/blame/a6d78fef508a3fd5dcaa397de746d0813bdfdff9/Classes/Domain/Service/NodePropertyConversionService.php#L47-L50

[mhsdesign]

And helllo there

neos-development-collection/Neos.ContentRepository.LegacyNodeMigration/Classes/NodeDataToAssetsProcessor.php

Line 46 in 6e1f233

// HACK the following line is required in order to fully initialize the node type

[bwaidelich]

Great to finally have a bug report for this – we kept hacking around this issue, as you realized :)

IMO we should just add the initialize() call to all methods in the NodeType that require it.

For 9.0 I still hope that we can turn the NodeType into a less magic self-translating, lazy-loading beast with #4228