Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts should do a simple upmerge for create-branch and create-changelog with skipping changes #70

Open
albe opened this issue Jul 2, 2021 · 2 comments

Comments

@albe
Copy link
Member

albe commented Jul 2, 2021

Currently, the create-branch script will adjust composer.json dependencies to the specific release version. A following upmerge can easily forget to reset those versions back to the dev-master defaults and hence the master ends up with wrong dependency versions making it impossible to install. (see neos/flow-base-distribution@49cdf3d for a manual correction commit of such an issue)
The same, but less critical, is the case for create-changelog, which creates a logfile that should not be upmerged and is only relevant for the current major+minor version. It often ends up being upmerged and needs to be deleted manually later. Even when not forgotten, it makes upmerging right after a release a tiny bit more tedious than otherwise.

Both can be prevented if the two scripts above would do a single upmerge similar to this:
git checkout origin/master && git merge --no-commit --no-ff $BRANCH && git reset HEAD composer.json && git commit -m "TASK: Upmerge dependency changes from $BRANCH"
Note: For the Framework/Neos packages the composer.json of all subpackages would need to be reset.

That would have to happen somewhere here: https://github.com/neos/flow-development-distribution/blob/master/Build/create-branch.sh#L58 and for all of the packages/folders or directly here https://github.com/neos/BuildEssentials/blob/master/ReleaseHelpers.sh#L30

In the case of the changelog, the upmerge would need to happen to the "next higher" branch, which is dynamic.

@mficzel
Copy link
Member

mficzel commented Aug 18, 2021

Hmm … disable push_branch and push_tag internally and imho it could be safe locally.

@mficzel
Copy link
Member

mficzel commented Aug 18, 2021

Maybe even an environment variable that can be set for a local only mode. Or that has to be set for the remote mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants