Experiment: Feature: http header abstraction for use in controllers #3290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Headers` class handles some cases for abstracting headers very well (e.g. `Cache-Control` and date based headers like `Last-Modified`) and should be the underlying ActionResponse API This change was originally part of @albe 's PR neos#2219 but reverted via "TASK: Revert Headers change". This reverts the revert commit aeb132d.
mhsdesign
changed the title
|
I will close this for now as we probably rather want more explicit helpers like the Cache Header helper instead or reviving the old header class. Also the ActionResponse doesn’t need to be enriched as we will deprecate it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3291
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions