You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What about the Cookie::createFromRawSetCookieHeader(...) method?
[...] Should we deprecate and remove it or try to make actual use of it (could be in a follow-up)?
This should be a minimal invasive change in order to be applied to all supported branches without too much risk.
If Cookie::createFromRawSetCookieHeader() is not used I'd be happy about a follow up that deprecates/removes it for master
I would mid term want to get rid of the whole Cookie object or remodel it maybe? IDK, sure a DTO to make getCookieParams/withCookieParams a bit nicer to use would be great, but right now the cookie object stems from our own http implementation way back. So anything we can cut from it is a win IMHO 😂
This should be a minimal invasive change in order to be applied to all supported branches without too much risk.
If
Cookie::createFromRawSetCookieHeader()
is not used I'd be happy about a follow up that deprecates/removes it formaster
copied from #2138 (comment)
The text was updated successfully, but these errors were encountered: