Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is Cookie::createFromRawSetCookieHeader unused? #3288

Open
mhsdesign opened this issue Jan 28, 2024 · 1 comment
Open

Why is Cookie::createFromRawSetCookieHeader unused? #3288

mhsdesign opened this issue Jan 28, 2024 · 1 comment

Comments

@mhsdesign
Copy link
Member

What about the Cookie::createFromRawSetCookieHeader(...) method?
[...] Should we deprecate and remove it or try to make actual use of it (could be in a follow-up)?

This should be a minimal invasive change in order to be applied to all supported branches without too much risk.
If Cookie::createFromRawSetCookieHeader() is not used I'd be happy about a follow up that deprecates/removes it for master

copied from #2138 (comment)

@mhsdesign
Copy link
Member Author

christian wrote:

I would mid term want to get rid of the whole Cookie object or remodel it maybe? IDK, sure a DTO to make getCookieParams/withCookieParams a bit nicer to use would be great, but right now the cookie object stems from our own http implementation way back. So anything we can cut from it is a win IMHO 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant