You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #3278 i was forced to adjust the types in the TextIterator and it came up if we even follow the correct specification or if this TextIterator should rather be dumped. Also #1039 mentions that the TextIterator should become more performant.
It seems that Flow has the only php implementation available for php6 never released TextIterator.
If we want to improve the TextIterator, for example adjust its documentation and possibly fix the implementation and make it faster, we can dug up the php6 code and let us be inspired by it:
I looked a bit into that supposed TextIterator and what happened to php 6 in general. And there is very little information on the web. And it all seemed to vanish :D
The behaviour of the TextIterator can be inferred from the original php6 code which resides in the experimental/first_unicode_implementation in the php-src repo.
But we can also just remove it and replace or deprecate the eel helpers String.cropAtWord and String.cropAtSentence which are the only consumers of the TextIterator.
The String.cropAtWord pr #864 already hides a native implementation in the first commit with no dependency on the TextIterator but only a few regex's.
The text was updated successfully, but these errors were encountered:
In #3278 i was forced to adjust the types in the
TextIterator
and it came up if we even follow the correct specification or if thisTextIterator
should rather be dumped. Also #1039 mentions that theTextIterator
should become more performant.It seems that Flow has the only php implementation available for php6 never released
TextIterator
.If we want to improve the
TextIterator
, for example adjust its documentation and possibly fix the implementation and make it faster, we can dug up the php6 code and let us be inspired by it:But we can also just remove it and replace or deprecate the eel helpers
String.cropAtWord
andString.cropAtSentence
which are the only consumers of theTextIterator
.The
String.cropAtWord
pr #864 already hides a native implementation in the first commit with no dependency on theTextIterator
but only a few regex's.The text was updated successfully, but these errors were encountered: