Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow file monitor should not traverse into node_modules #3266

Open
mhsdesign opened this issue Jan 18, 2024 · 0 comments
Open

Flow file monitor should not traverse into node_modules #3266

mhsdesign opened this issue Jan 18, 2024 · 0 comments

Comments

@mhsdesign
Copy link
Member

There is currently no guarding against monitoring everything out of node_modules.
As this is such a common preserved folder i would not expect anyone sane for using it for real. And in turn expect flow to not traverse into it while listening for changes:

protected function readMonitoredDirectoryRecursively($path, $filenamePattern)
{
$directories = [Files::getNormalizedPath($path)];
while ($directories !== []) {
$currentDirectory = array_pop($directories);
if (is_file($currentDirectory . '.flowFileMonitorIgnore')) {
continue;
}

I did not measure the impact but i simply cannot imagine that accidentally monitoring node_modules is ever a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant