Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Image collage with randomly positioned images #553

Merged
merged 25 commits into from Feb 22, 2024

Conversation

rtp-cgs
Copy link

@rtp-cgs rtp-cgs commented Nov 23, 2023

This is only a first draft of the automatic positioning of the images.

Todos:

  • Ensure dynamic image sizes work with the positioning script
  • Implement Parallax
  • Adding square icon components

@jonnitto jonnitto changed the title [TASK] WIP - First draft of image collage with randomly positioned im… TASK: WIP - First draft of image collage with randomly positioned im… Nov 23, 2023
@jonnitto jonnitto marked this pull request as draft November 23, 2023 16:22
@jonnitto jonnitto changed the title TASK: WIP - First draft of image collage with randomly positioned im… TASK: Image collage with randomly positioned images Nov 23, 2023
@nmuens
Copy link
Collaborator

nmuens commented Feb 14, 2024

@rtp-cgs
do you take place in the online sprint next week to finish this component? Or can you update what was already be done and what has to be done, so that others can go on?

@rtp-cgs
Copy link
Author

rtp-cgs commented Feb 14, 2024

@nmuens As of now unfortunately I won't have time to attend. I might be able to attend a day or two, I will update you via Slack beginning of next week.

The Todo's in comment #1 should still be up to date.

@jonnitto jonnitto linked an issue Feb 20, 2024 that may be closed by this pull request
@bbehrendt-mm
Copy link
Collaborator

I can take care of this.

@bbehrendt-mm bbehrendt-mm self-assigned this Feb 20, 2024
@@ -18,4 +19,6 @@ Alpine.plugin([

window.Alpine = Alpine;

Alpine.data('ImageCollage', ImageCollage);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set Alpine.data() directly in the ImageCollage file

@jonnitto jonnitto marked this pull request as ready for review February 20, 2024 12:32
@jonnitto jonnitto marked this pull request as draft February 20, 2024 12:36
@jonnitto jonnitto marked this pull request as ready for review February 22, 2024 11:19
@jonnitto jonnitto merged commit ee09081 into neos:rebrand Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageCollage automatic image positioning
4 participants