Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MongoConnection class functions #31

Open
naorlivne opened this issue Apr 8, 2019 · 0 comments
Open

Refactor MongoConnection class functions #31

naorlivne opened this issue Apr 8, 2019 · 0 comments
Labels
enhancement Hacktoberfest help wanted low priority

Comments

@naorlivne
Copy link
Member

Expected/Wanted Behavior

There should be the following generic functions:

  • mongo_get
  • mongo_check_exists
  • mongo_list
  • mongo_delete (combined with mongo_remove)
  • mongo_update

Which are used rather then the current state of having a lot of functions that are similar but don't share any code.

Actual Behavior

A lot of functions in the MongoConnection class are just copy paste with very small alterations.

Specifications

It should be noted that not all can be generalized as some functions as a unique use case so functions should be generalized on a case by case basis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Hacktoberfest help wanted low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@naorlivne