Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] - Add tests to the Docker images #2

Open
3 tasks
trallard opened this issue Jun 8, 2022 · 4 comments
Open
3 tasks

[DEV] - Add tests to the Docker images #2

trallard opened this issue Jun 8, 2022 · 4 comments
Labels
area: testing ✅ Items related to testing type: enhancement 💅🏼 New feature or request

Comments

@trallard
Copy link
Member

trallard commented Jun 8, 2022

A CI/CD workflow should test the images after the build and before pushing.

Tasks

  • Identify and add common tests (for all images)
  • Identify and add any image specific tests
  • Add step to GH action workflow
@trallard trallard added type: enhancement 💅🏼 New feature or request area: testing ✅ Items related to testing labels Jun 8, 2022
@trallard trallard changed the title [DEV] - Add tests to the images [DEV] - Add tests to the Docker images Jul 5, 2022
@trallard
Copy link
Member Author

@trallard
Copy link
Member Author

Also explore - https://github.com/NVIDIA/container-canary

@viniciusdc
Copy link
Contributor

Work in progress finished setting up the workflow ecosystem, currently:

  • Writing the docker wrapper to interact with the built images and execute the pytest scripts
  • Writing specialized tests for each image
  • Will need to rebase to sync with main

@viniciusdc
Copy link
Contributor

I am mostly following the workflow structure defined on jupyter/docker-stacks, right now I've set the workflow ecosystem and was working on setting pytest-docker to run the pytest scripts in the image containers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: testing ✅ Items related to testing type: enhancement 💅🏼 New feature or request
Projects
Status: Ready 🔔
Status: Backlog 🗃
Development

Successfully merging a pull request may close this issue.

2 participants