Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Start button hidden behind version footer in Server Options selector #95

Closed
pavithraes opened this issue Feb 1, 2024 · 3 comments

Comments

@pavithraes
Copy link
Member

pavithraes commented Feb 1, 2024

Context

In the "Server Options" page, the Start button is currently hidden behind it when we have several options that need the page to be scrollable:

Screen.Recording.2024-02-02.at.12.47.16.AM.mov

The recording shows the maximum scroll.

I believe the version display footer was styled in

.version {
position: fixed;
bottom: 0;
left: 0;
z-index: 99; /* Make sure it does not overlap */
width: 100%;
padding: 5px 20px;
background-color: #fff;
color: var(--primary-color);
text-align: start;
font-size: 1rem; /* Increase font size */
font-family: var(--base-font-family);
word-wrap: break-word;
border-top: 1px solid #e6e6e6;
}

Value and/or benefit

Better expereince to start JupyterLab.

Anything else?

I'm using the Quansight Nebari instance.

In case this bug is not relevant here, please feel free to move this to the correct repo.

@pavithraes pavithraes added needs: triage 🚦 Someone needs to have a look at this issue and triage area: user experience 👩🏻‍💻 type: bug 🐛 Something isn't working and removed needs: triage 🚦 Someone needs to have a look at this issue and triage labels Feb 1, 2024
@kcpevey
Copy link
Contributor

kcpevey commented Feb 5, 2024

This page will likely be rewritten in React in the near future. If it is included in the react redesign, we can just wait until that is complete (per Dharhas)

@jbouder
Copy link
Collaborator

jbouder commented Feb 5, 2024

Definitely a result of the recent footer changes. My update caused the footer to span the entire bottom which I believe was originally in the corner. A short term fix might be to disable the footer by setting display_version: False in the JupyterHub config and/or the nebari config.

And should be able to wait for the rewrite, but if needed we should be able to fix this pretty easily in the current JupyerHub UI.

@jbouder
Copy link
Collaborator

jbouder commented Feb 23, 2024

The above should resolve this issue. This should be ready to close

@jbouder jbouder closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants