Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate code #5

Open
nkaretnikov opened this issue Dec 5, 2023 · 0 comments
Open

Avoid duplicate code #5

nkaretnikov opened this issue Dec 5, 2023 · 0 comments
Labels
needs: triage 🚦 Someone needs to have a look at this issue and triage

Comments

@nkaretnikov
Copy link
Collaborator

Context

Currently, code for scheduled and non-scheduled workflows is repeated twice. It's worth refactoring. See:
https://github.com/nebari-dev/argo-jupyter-scheduler/pull/3/files#r1415329914

Value and/or benefit

Avoiding mistakes due to one version being not updated when refactoring.

Anything else?

No response
@nkaretnikov nkaretnikov added the needs: triage 🚦 Someone needs to have a look at this issue and triage label Dec 5, 2023
@nkaretnikov nkaretnikov mentioned this issue Dec 5, 2023
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs: triage 🚦 Someone needs to have a look at this issue and triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nkaretnikov