Inconsistent @NonNull annotation usage

[hadiidbouk]

Hello,

The registerLocationListener (unregisterLocationListener) method in AndroidLocationProvider are not nullable

registerLocationListener(@NonNull LocationListener locationListener)

But the same method in the IndoorPositioning (Which should be named IndoorPositioningProvider - i guess) are nullable.

registerLocationListener(LocationListener locationListener)

Can we follow the same convention in both methods ?

[Steppschuh]

That's true, but won't change anytime soon. It's because the @NonNull annotation is part of android.support.annotation and thus not available in the Java core library.

[hadiidbouk]

But isn't the Java 8 contains a @NonNull annotation ?

Check this

[Steppschuh]

Thanks for the heads up. We'll see if and how we can combine these annotations.