Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused method #118

Open
hadiidbouk opened this issue Aug 6, 2018 · 1 comment
Open

Unused method #118

hadiidbouk opened this issue Aug 6, 2018 · 1 comment

Comments

@hadiidbouk
Copy link

What is the reason for having this method in Beacon.java class?
Should be changed? or removed?

public void applyPropertiesFromAdvertisingPacket(P advertisingPacket) {
        //setTransmissionPower(lastAdvertisingPacket.get);
}
@marvinmirtschin
Copy link
Contributor

The method is overridden in the child classes of Beacon therefore we can not remove it.
I agree that we should change the method to either do something (e.g. to set the transmission power) or make it abstract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants