Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional sub-plotting options #25

Open
ndphillips opened this issue Jul 14, 2017 · 4 comments
Open

Add additional sub-plotting options #25

ndphillips opened this issue Jul 14, 2017 · 4 comments

Comments

@ndphillips
Copy link
Owner

in plot.FFTrees(), add options to only show ROC curve, and main tree with icons

@ndphillips
Copy link
Owner Author

Need to restructure the layout of plot.FFTrees pretty heavily. It's a bit of a mess right now :)

@hneth
Copy link
Collaborator

hneth commented Jul 26, 2022

Started to re-structure plot.FFTrees(), but splitting into multiple parts (e.g., ROC curve as separate function) may facilitate maintenance.

When trying to call showcues() with data = "test" (e.g.,
plot(heart.fft, data = "test", what = "cues") for heart.fft with test data)
I only get the Error: "There are no test statistics for this object."
Is this a bug or a feature?

@hneth
Copy link
Collaborator

hneth commented Sep 1, 2022

The release of FFTrees 1.7.0 has fixed the most obvious plotting issues, but the corresponding code is still pretty bulky and should be simplified further. Beyond additional cleanups, I'd advocate using more intuitive plotting options.

Issue: The interplay between what and stats seems redundant, as the only function of stats is to hide some options. Also, the default of what = "tree" is counter-intuitive, as the real default appears to be to plot 'all' or 'everything', whereas the "tree" intuitively seems to denote the tree diagram in the center.

Suggestion:

  • Change what options to a new default setting what = 'all', which enables all options.

  • By contrast, what = 'tree' only plots the tree diagram (i.e., replacing stats = FALSE).

This would leave the current defaults (i.e., showing everything, when nothing has been specified) intact,
but allow for more nuanced selections, e.g., using what = 'tree' with additional options.

  • Deprecate stats by correcting user inputs of stats = FALSE to what = 'tree' instead.

@hneth hneth self-assigned this Sep 9, 2022
@hneth hneth removed their assignment Sep 14, 2022
@hneth
Copy link
Collaborator

hneth commented Sep 16, 2022

I'd consider the most immediate needs to be addressed in the recent release of FFTrees version 1.7.5 (on 2022-09-15).

However, as new ideas/needs may arise and plot.FFTrees() is still pretty clunky, I suggest keeping this issue open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants