Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loss of context in breadcrumb labels #176

Open
YuriMasyanISS opened this issue Mar 10, 2017 · 1 comment
Open

Loss of context in breadcrumb labels #176

YuriMasyanISS opened this issue Mar 10, 2017 · 1 comment

Comments

@YuriMasyanISS
Copy link

here's my Plunk: http://plnkr.co/edit/8m2kpi8mtr9jTLF5wI00?p=preview

I have two sibbling (for ui-router) states (state1 and state2).

In state2: ncyBreadcrumb: parent: 'state1'

Both have similar labels: ncyBreadcrumb: label: '{{label}}'

They have similar controllers like:
controller: function ($scope) {$scope.label = 'label 1'}
and
controller: function ($scope) {$scope.label = 'label 2'}

According to API-Reference:

The property ncyBreadcrumbLabel can contains bindings which are evaluated against the scope of the current state controller. For example, this state's config ...

I see that bindings of both ncyBreadcrumbLabel in "step in steps" are corresponding to the same last controller in chain.
Isn't each scope in breadcrumb step supposed to refer to the state controller it was defined in?
Can i define each label in its own state dynamically, so that it would be properly displayed no matter its sorrounding is?

ps.: i also noticed it's extremely easy to shutdown browser by assignment to state2: ncyBreadcrumb: parent: state2 with no error in console

@YuriMasyanISS YuriMasyanISS changed the title Loss of context in the label Loss of context in the breadcrumb labels Mar 10, 2017
@YuriMasyanISS YuriMasyanISS reopened this Mar 10, 2017
@YuriMasyanISS YuriMasyanISS changed the title Loss of context in the breadcrumb labels Loss of context in breadcrumb labels Mar 10, 2017
@nhim175
Copy link

nhim175 commented May 5, 2017

I got the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants