Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Idea] : Retro music in Navidrome #2894

Closed
3 tasks done
Beulu opened this issue Mar 8, 2024 · 10 comments
Closed
3 tasks done

[Idea] : Retro music in Navidrome #2894

Beulu opened this issue Mar 8, 2024 · 10 comments
Labels
bug triage New bug reports that need to be evaluated

Comments

@Beulu
Copy link

Beulu commented Mar 8, 2024

I confirm that:

  • I have searched the existing open AND closed issues to see if an issue already exists for the bug I've encountered
  • I'm using the latest version (your issue may have been fixed already)

Version

Latest

Current Behavior

Navidrome reading vgm, vgz, gym...

Expected Behavior

This new feature ^^

How Navidrome is installed?

Docker

  • I agree to follow Navidrome's Code of Conduct

Hi !

I saw this closed conversation : #1929 and I jsut ask why you don't insert source code of Game Music Emu in Navidrome (or for a plug in ?)

Thanks !

P.S. : sorry for the bug tag :\

@Beulu Beulu added bug triage New bug reports that need to be evaluated labels Mar 8, 2024
@risalt
Copy link

risalt commented Apr 5, 2024

+1 😀

@hologarden
Copy link

hologarden commented May 5, 2024

Likely too little demand for it to be implemented. As seen in #1929:

[...] taglib does not support reading those formats yet. Thank you for your ideas though!

Though it has been referenced in the issues of the official taglib repo. You could always try forking Navidrome to try implementing the feature on your own!

There is also a dedicated page to ideas for new features.

@deluan
Copy link
Member

deluan commented May 7, 2024

If ffmpeg support these formats, you can change your extractor to ffmpeg (ND_SCANNER_EXTRACTOR=ffmpeg).

You would also need to add the mime types to your system. You may try to override the mime_types.yaml file (only in development builds) by creating a resources directory under the same directory that holds your navidrome.db file, and create a modified coy of the mime_types.yaml inside it:

data_folder/
  navidrome.db
  resources/
     mime_types.yaml

Anyway, closing this as there is nothing much that Navidrome can do if taglib or ffmpeg do not support these file formats.

@deluan deluan closed this as completed May 7, 2024
@Beulu
Copy link
Author

Beulu commented May 8, 2024

Thanks all for your answers.

deluan : you mean I need to code ? Because I can't. Or is this just a configuration by file/options modifications ?

@deluan
Copy link
Member

deluan commented May 8, 2024

No coding required, you just need to create a copy of the mime_types.yaml file in the folder I mentioned above, and add the mime type for the file types you want.

Example, for vgm file format, I googled "vgm mime type" and found this: https://www.digipres.org/formats/sources/wikidata/formats/#q105863074

So you would add a line in the mime_type.yaml file like this in the "types" section (just follow the pattern in the file for other formats):

  .vgm: audio/x-mod

But this will only work if ffmpeg can recognize the file. You can test it by going to the command line and running:

ffmpeg -i your_file.vgm

and check if it shows valid information about the file, like title, artist, album. If not, the files will be impoirted, but will be classified as Unknown Artist/Unknown Album

Hope this helps.

@Beulu
Copy link
Author

Beulu commented May 8, 2024

OK, with Windows and command bat I got this :

image

Seems ffmpeg reads .vgm.

Great, got this too :

image

Seems ffmpeg reads .vgz !

VLC needs to "unzip" .vgz to be read (and take more space disk)

Great stuff too, files got metadata !

I'm sorry in advance because configuration is not my best part. Working on it. Try to investigate your method.

Thanks again !

@deluan
Copy link
Member

deluan commented May 8, 2024

Good news is that ffmpeg can read metadata. Bad news is that your files are using non-standard tags: song for title, author for artist. So Navidrome won't be able to map these correctly. You'll need to change it to match standard tags.

@Beulu
Copy link
Author

Beulu commented May 8, 2024

Damn ! I'm not motivated to change those metadata for all files. Maybe if I find a library with modified tags.

You mean if I upgrade mime_types.yaml navidrome will read game musics, even if metadatas are not good ? Is it possible to add it for future updates ? Is it possible to convert song to title and author for artist automatically for all those specific files ?

Thanks !

@deluan
Copy link
Member

deluan commented May 8, 2024

You mean if I upgrade mime_types.yaml navidrome will read game musics, even if metadatas are not good ?

Yes, but they will show as Unknown Artist/Unknown Album

Is it possible to add it for future updates ?

In the new scanner I'm working on (#2709), you'll be able to map tags similar to how you map mime types. So yes, you'll be able to configure this.

Is it possible to convert song to title and author for artist automatically for all those specific files ?

Maybe you can find a tool that does the mapping for you? I think you may use MusicBrainz Picard for that, or maybe other taggers, but I'm not sure.

@Beulu
Copy link
Author

Beulu commented May 8, 2024

You mean if I upgrade mime_types.yaml navidrome will read game musics, even if metadatas are not good ?

Yes, but they will show as Unknown Artist/Unknown Album

Nevermind ! (for the moment ^^)

Is it possible to add it for future updates ?

In the new scanner I'm working on (#2709), you'll be able to map tags similar to how you map mime types. So yes, you'll be able to configure this.

Great news ! I was stucked on hologarden response.

Is it possible to convert song to title and author for artist automatically for all those specific files ?

Maybe you can find a tool that does the mapping for you? I think you may use MusicBrainz Picard for that, or maybe other taggers, but I'm not sure.

I'll checked with Musicbee, maybe try MusicBrainz and/or find a good place to download welltag albums.

I really would try if it's working but i'm not sure about linux manipulations and don't want to break everything...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage New bug reports that need to be evaluated
Projects
None yet
Development

No branches or pull requests

4 participants