Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Models nullability review 2 #352

Open
mtmk opened this issue Jan 24, 2024 · 0 comments
Open

Models nullability review 2 #352

mtmk opened this issue Jan 24, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mtmk
Copy link
Collaborator

mtmk commented Jan 24, 2024 •
edited

In addition to the earlier work on models review these models too:

  • NATS.Client.Services.Models
  • and NATS.Client.ObjectStore.Models

Workflow

  1. Remove any default! assignments
  2. Stick "required" on non-nullable reference types that don't have a default value
  3. Add ? to all the optional reference types

see also #300
cc @mnmr
@mtmk mtmk added the bug Something isn't working label Jan 24, 2024
@mtmk mtmk added enhancement New feature or request and removed bug Something isn't working labels Feb 6, 2024
@mtmk mtmk added the help wanted Extra attention is needed label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mtmk