Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg-config file is broken when CMAKE_INSTALL_LIBDIR is absolute #542

Open
alexshpilkin opened this issue May 17, 2022 · 1 comment
Open

Comments

@alexshpilkin
Copy link

alexshpilkin commented May 17, 2022

As per title: src/libnats.pc.in has

prefix="@CMAKE_INSTALL_PREFIX@"
exec_prefix="${prefix}"
libdir="${prefix}/@CMAKE_INSTALL_LIBDIR@"

and so can’t handle absolute paths in CMAKE_INSTALL_LIBDIR. This leads to broken .pc files on NixOS in particular.

See “Concatenating paths when building pkg-config files” for a thorough discussion of the problem and a suggested fix, or KDE’s extra-cmake-modules for a simpler approach.

@kozlovic
Copy link
Member

@alexshpilkin The pkg-config file was added by an external contributor. Would you mind contributing at fixing this since it looks like you have a grasp on what the exact issue is and how to reproduce (and therefore verify the fix)?
If requiring CMake 3.20.0 is better, I think that this is a reasonable change to make too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants