Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Split-Grid]: typo in typescript types #784

Open
nclemeur opened this issue Jul 4, 2023 · 4 comments
Open

[Split-Grid]: typo in typescript types #784

nclemeur opened this issue Jul 4, 2023 · 4 comments

Comments

@nclemeur
Copy link
Contributor

nclemeur commented Jul 4, 2023

I believe that the types definitions should be fixed for GridTemplateProperty:
export type GridTemplateProperty = 'grid-template-column' | 'grid-template-row';

It should be
export type GridTemplateProperty = 'grid-template-columns' | 'grid-template-rows';

(note the extra 's' at the end)

@nathancahill
Copy link
Owner

Thanks, can you submit a PR with this change?

nclemeur added a commit to nclemeur/split that referenced this issue Jul 4, 2023
Fixing type in typescript types to refer to the correct css properties
nclemeur added a commit to nclemeur/split that referenced this issue Jul 4, 2023
@nclemeur
Copy link
Contributor Author

nclemeur commented Jul 4, 2023

I have tried, but this is a bit of a new process for m, so hopefully it will be fine

@kotasudhakar
Copy link

this issue is good to be closed i guess

@nclemeur
Copy link
Contributor Author

nclemeur commented Jul 9, 2023

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants