Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publishing): no index.html on npm pack #7699

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(publishing): no index.html on npm pack #7699

wants to merge 2 commits into from

Conversation

evenstensberg
Copy link
Contributor

@evenstensberg evenstensberg commented Apr 17, 2024 •
edited by ozyx

Describe your changes:

Fixes #7680

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx self-requested a review April 17, 2024 20:23
@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Apr 17, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Apr 17, 2024
@ozyx ozyx added the source:community Community contribution or request label Apr 17, 2024
@unlikelyzero unlikelyzero self-requested a review April 25, 2024 22:01
ozyx
ozyx approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb notable_change A change which should be noted in the changelog labels Apr 30, 2024
@ozyx ozyx enabled auto-merge (squash) April 30, 2024 22:50
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.38%. Comparing base (b3d3465) to head (ad1d7b4).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7699      +/-   ##
==========================================
- Coverage   56.72%   56.38%   -0.34%     
==========================================
  Files         673      673              
  Lines       27185    27185              
  Branches     2635     2635              
==========================================
- Hits        15421    15329      -92     
- Misses      11434    11526      +92     
  Partials      330      330
Flag Coverage Δ
e2e-full 23.55% <ø> (-18.23%) ⬇️
e2e-stable 59.97% <ø> (-0.02%) ⬇️
unit 49.20% <ø> (-0.05%) ⬇️

see 12 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d3465...ad1d7b4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozyx ozyx ozyx approved these changes

@unlikelyzero unlikelyzero unlikelyzero approved these changes

Assignees
No one assigned
Labels
notable_change A change which should be noted in the changelog pr:e2e:couchdb npm run test:e2e:couchdb source:community Community contribution or request type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging this pull request may close these issues.

Example index.html should not be included in npm distributable
4 participants
@evenstensberg @codecov-commenter @ozyx @unlikelyzero