Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] Use the dismiss button to close time popup (rather than the submit button) #7614

Closed
shefalijoshi opened this issue Mar 18, 2024 · 2 comments · Fixed by #7613
Closed

[e2e] Use the dismiss button to close time popup (rather than the submit button) #7614

shefalijoshi opened this issue Mar 18, 2024 · 2 comments · Fixed by #7613
Labels
type:maintenance tests, chores, or project maintenance verified Tested or intentionally closed
Milestone
Target:4.0.0

Comments

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Mar 18, 2024 •
edited

Summary

Using the submit button to dismiss the time conductor popup is currently causing tests to fail in the openmct-yamcs repo.
As a short term fix, use the close time conductor button instead.

An issue has been created to optimize behavior of the Submit button in cases where there are no changes to submit. #7616
@shefalijoshi shefalijoshi added the type:maintenance tests, chores, or project maintenance label Mar 18, 2024
@shefalijoshi shefalijoshi added this to the Target:4.0.0 milestone Mar 18, 2024
@shefalijoshi shefalijoshi mentioned this issue Mar 18, 2024
Merged
14 tasks
@shefalijoshi
Copy link
Contributor Author

Testing instructions:
All openmct and openmct-yamcs e2e tests should pass with this change.
See respective READMEs for instructions.

@shefalijoshi shefalijoshi self-assigned this Mar 18, 2024
@shefalijoshi shefalijoshi added verified Tested or intentionally closed and removed verified Tested or intentionally closed labels Mar 19, 2024
@shefalijoshi
Copy link
Contributor Author

Verified Fixed.

@akhenry akhenry assigned ozyx and unassigned shefalijoshi Mar 19, 2024
@ozyx ozyx removed their assignment Mar 20, 2024
@ozyx ozyx added verified Tested or intentionally closed invalid duplicate or incorrectly filed and removed verified Tested or intentionally closed invalid duplicate or incorrectly filed labels Mar 20, 2024
@ozyx ozyx changed the title Use the dismiss button to close time popup (rather than the submit button) [e2e] Use the dismiss button to close time popup (rather than the submit button) Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance verified Tested or intentionally closed
Projects
None yet
Milestone
Target:4.0.0
2 participants
@shefalijoshi @ozyx