Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region in config should be separate between img and the created instances #1460

Open
unusualevent opened this issue May 10, 2023 · 6 comments
Labels

Comments

@unusualevent
Copy link
Contributor

the region for uploading an image in the config for vultr is ewr1, but the closest "region" for creating an instance is "ewr".

the keys between the image upload and the instance creation should be distinct.

currently I have to set the region in the CLI option (for the instance region) to overwrite the config.json (which holds the image region).

@eyberg eyberg added the vultr label May 11, 2023
@eyberg
Copy link
Contributor

eyberg commented May 11, 2023

regions and zones are a bit conflated in various providers (iirc mainly because of aws volumes) - so we basically force labeling zones everywhere and then infer regions from that (see https://github.com/nanovms/ops/blob/master/provider/aws/aws.go#L41 )

I think keeping with this behavior vultr would want the same functionality if it isn't using it

@unusualevent
Copy link
Contributor Author

fair - is it possible to update your documentation to clarify that?

e.g. changing the docs:

  • that the region/zone in the CLI overrides the one in the file
  • that you should set the region/zone of the image in the config.json, and specify the region of the instance in the cli args?

vs changing the code:

  • rename Region/Zone to ImageRegion/ImageZone and InstanceZone/RegionZone keys in the config.json

@eyberg
Copy link
Contributor

eyberg commented May 11, 2023

we definitely can - any prs to https://github.com/nanovms/ops-documentation once approved go live instantly

@unusualevent
Copy link
Contributor Author

oh I'm definitely not a wordsmith.

@eyberg
Copy link
Contributor

eyberg commented May 25, 2023

w/ #1473 you can use 'ewr1' for both - this follows the convention we're using for other providers

@unusualevent
Copy link
Contributor Author

then the docs should be updated to change it from "ewr" to "ewr1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants