Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #if __GNUC__ conditions and its cases #383

Open
mloskot opened this issue Apr 4, 2023 · 0 comments
Open

Remove #if __GNUC__ conditions and its cases #383

mloskot opened this issue Apr 4, 2023 · 0 comments
Labels
category/refactoring Any nonfunctional changes good-first-issue Opportunity for new contributors to help us
Milestone

Comments

@mloskot
Copy link
Member

mloskot commented Apr 4, 2023

As pointed in #382 (comment), since we are at C++14 already, cases like this one can go

#elif defined(__GNUC__) && (__GNUC__ < 5)
#include <cwchar>

The oldest GCC version we are testing is

- { cxxstd: '14', cxx: g++-5, cc: gcc-5, os: ubuntu-18.04 }

@mloskot mloskot added category/refactoring Any nonfunctional changes good-first-issue Opportunity for new contributors to help us labels Apr 4, 2023
@mloskot mloskot added this to the 2.15+ milestone Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/refactoring Any nonfunctional changes good-first-issue Opportunity for new contributors to help us
Projects
None yet
Development

No branches or pull requests

1 participant