Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Disc sort in albums #167

Open
cyberbasty opened this issue Apr 11, 2024 · 10 comments
Open

[FEATURE REQUEST] Disc sort in albums #167

cyberbasty opened this issue Apr 11, 2024 · 10 comments

Comments

@cyberbasty
Copy link

cyberbasty commented Apr 11, 2024

Hi man, your app is so cool i love it and i have an idea for a small feat tha can be really cool to add : disc sorr in albums (i dont know how to call it but i provide you some pictures)

My previous music player was oto music and it had this feature, so, if you feel like you can do it, it would be really nice.

Thanks in advance

Screenshot_2024-04-11-23-43-46-669_com.piyush.music.jpg

Screenshot_2024-04-11-23-43-53-763_com.piyush.music.jpg

@cyberbasty cyberbasty changed the title [FEATURE REQUEST] [FEATURE REQUEST] Disc sort in albums Apr 11, 2024
@MSOB7YY
Copy link
Member

MSOB7YY commented Apr 11, 2024

i remember being asked for this before, alr sure but can u send me 2-3 tracks with different disk number in order to do it properly? (am pretty sure i can just edit my tags but wanna make sure)

also u are as cool too <3

@cyberbasty
Copy link
Author

Sorry i didnt entirely understand what you want to do...
My songs are being detectd as part of a disc because of the foldersScreenshot_2024-04-12-00-22-31-083_ru.zdevs.zarchiver.jpg

@MSOB7YY
Copy link
Member

MSOB7YY commented Apr 11, 2024

are u sure it's only bcz of folders or is it the disc number tag in tracks metadata tag, i was asking for a sample of few tracks

@cyberbasty
Copy link
Author

Maybe bothScreenshot_2024-04-12-00-38-10-971_com.piyush.music.jpg

@cyberbasty
Copy link
Author

I think i found how to sort them but is it possible to have the list saying like

disc 1
Then the disc 1 tracks

Disc 2
Then the disc 1 tracks

Instead of like on this picture ?Screenshot_2024-04-12-00-41-53-628_com.msob7y.namida.jpg

@cyberbasty
Copy link
Author

Maybe you should enable the disc metadata sort by default, but otherwise it's a great app (with a gread icon XD)

@MSOB7YY
Copy link
Member

MSOB7YY commented Apr 11, 2024

well yeah they are by default sorted by track number then year then track title.

now that u sorted them properly, this is considered as done right? i don't plan on changing the default idk (yep gread icon xD)

@cyberbasty
Copy link
Author

cyberbasty commented Apr 11, 2024

Maybe adding a separator between discs with the disc number

But otherwise i think it's doneIMG_20240412_011036.jpg

@cyberbasty
Copy link
Author

Thanks for those reply :)

@MSOB7YY
Copy link
Member

MSOB7YY commented Apr 12, 2024

will check if i can, in my case for example i use album tag for channel name while downloading from yt, so not all albums are properly disc separated. will check again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants