Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While sliding time to change YouTube video playback; thumbnail is showed and audio plays. #137

Open
idontveapc opened this issue Feb 25, 2024 · 12 comments

Comments

@idontveapc
Copy link

When ever you change video playback duration the video thumbnail shows up and just audio plays from that duration. No image moves.

@MSOB7YY
Copy link
Member

MSOB7YY commented Feb 26, 2024

do u have any video to showcase? everything works fine on my side

@idontveapc
Copy link
Author

For me every video does that

@MSOB7YY
Copy link
Member

MSOB7YY commented Feb 27, 2024

nah i mean a video u record showing the bug

@OwenD30
Copy link

OwenD30 commented Mar 4, 2024

I can confirm I also have this issue. I wasn't able to replicate it while screen recording, but it's exactly as described: you scroll back and it starts playing audio only with the cover even though a video mode is selected. Here's a screen recording demonstrating that I can fast forward fine but going backwards never works.

screen-20240304-0030343.1.1.1.mp4

Right after I finished this recording it started displaying the thumbnail and audio only despite it being set to 1080p.

Other issues: the app seems to really tax my CPU (it doesn't run very smooth) and drains my battery. I have a pixel 7. Idk if this is efficiency related or just a result of having so many features on one app.

Also, sometimes if I go back to another song quickly by going next then previous it leaves off at the same time as when I skipped it. See below:

screen-20240304-004811.1.mp4

However, these are all issues that can be fixed and I wanted to thank you for your insane amount of work on this app. It's crazy you were able to do this on your own and release it for free. Super hype for future YT Music integration :-)

@OwenD30
Copy link

OwenD30 commented Mar 4, 2024

Edit: how quick I move between songs doesn't affect it starting from where I left off. It does it no matter what.

@MSOB7YY
Copy link
Member

MSOB7YY commented Mar 4, 2024

@OwenD30 thanks for providing detailed report, here is some explanation:

  1. video playback turns off/bugs when seeking backwards
    • gonna investigate in this, the playback is kinda sensitive cuz of how caching works (it opens a local proxy server and redirect to exoplayer), gonna see
  2. getting smooth experience is still achievable
    • u gotta make sure that blur, glow, parallax is off from customization settings
    • u can just enable balanced/performance mode from advanced settings, this will do the same + reduce image quality
    • auto coloring is also kinda expensive, u can disable it too (along with "force miniplayer to follow colors") to remove lag while switching tracks
  3. track continuing from last played position
    • that's a feature lmao, u can tweak that in playback settings > minimum track duration to restore last position, increase it to a desired number or until u disable it

also thanks a lot for ur nice words, im just glad ppl still appreciate like u do 💖

@OwenD30
Copy link

OwenD30 commented Mar 4, 2024

Awesome. Thank you so much.

I noticed too that sometimes the playing audio only while in video mode bug happens when you finish a video and hit play to start it over again. But not always.

Also, the comment replies button has never done anything when I tapped it. I think it should show the comment replies?

@OwenD30
Copy link

OwenD30 commented Mar 4, 2024

Haha one more thing: the "v" in "views" under the channel page should be capitalized, I only notice this because the rest of the app is so polished :-)

Screenshot_20240304-181302.png

@MSOB7YY
Copy link
Member

MSOB7YY commented Mar 5, 2024

@OwenD30 alr imma investigate this video bug

comment replies is not implemented yet

and oki will capitalize "views"... BUT BRO WHY UR FONT SO BIG 😭

@MSOB7YY
Copy link
Member

MSOB7YY commented Mar 5, 2024

also i noticed ur miniplayer is on top of navbar without background.. is this normal?

@OwenD30
Copy link

OwenD30 commented Mar 5, 2024

Haha for some reason I like the bigger fonts look for this app 😂

Yeah for the videos it looks like this

Screenshot_20240304-195550.png

And for music it looks normal

Screenshot_20240304-195614.png

Also, just remembered that when switching songs without a Bluetooth device connected my phone speakers make very loud blips sometimes.

@MSOB7YY
Copy link
Member

MSOB7YY commented Apr 11, 2024

is this still issue after v2.0.6?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants