Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token is saved in .github-todos, which is not in .gitignore by default #27

Open
davidascher opened this issue Oct 30, 2016 · 0 comments

Comments

@davidascher
Copy link

The CLI says: Those information ARE NOT STORED, only the generated token will be stored in your global git configuration. (by which I assume it means e.g. ~/.gitconfig), but in my experience if you do:

github-todos config github.token <TOKEN>

then it ends up in .github-todos, not in the global config file. This makes it easy to accidentally checkin the token, which I believe one shouldn't do.

I like the idea of doing what the CLI says it'll do, but if it doesn't, it should probably instead say "make sure you add .github-todos to your .gitignore".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant