Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 support #16

Open
MikulasZelinka opened this issue Mar 2, 2018 · 4 comments
Open

Python 3 support #16

MikulasZelinka opened this issue Mar 2, 2018 · 4 comments

Comments

@MikulasZelinka
Copy link

MikulasZelinka commented Mar 2, 2018

Hello,

are you planning on supporting Python 3, please?

If I wanted to try to make it work in Python 3, was there any particular problem with Python 3 that you've encountered (e.g. are there some dependencies which also don't support it)?

Thanks :)

@n1nj4sec
Copy link
Owner

n1nj4sec commented May 5, 2018

Hello,
You should be fine there is no dependencies in this project, everything is implemented in ctypes

@Mehodin
Copy link

Mehodin commented May 12, 2018

https://mehodin.com/i/9447dcac.png <- Getting that error tho, how to fix?

@matslindh
Copy link

There's a set of fixes necessary (imports, print-statements, fixing setup.py, handling bytes vs strings) to get memorpy to run properly under python3, but I have a version running. I'll make a PR in a day or two - but I've only tested it under Windows.

As there seems to be no tests available I can't confirm that I haven't broken something outside of the functions I'm using myself.

@matslindh
Copy link

matslindh commented Jul 7, 2018

I've added a #20 as an initial set of fixes to make memorpy work under Python 3. Since my usage was limited to Windows this time, I haven't tested the patch with other OS-es or that it is in any way backwards compatible with Python 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants