Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: interface for next_day should match other next_*/last_* methods. #76

Open
liavkoren opened this issue Nov 30, 2015 · 2 comments

Comments

@liavkoren
Copy link

In [90]: d.next_second()
Out[90]: Delorean(datetime=2014-03-01 05:00:01+00:00, timezone=utc)

In [91]: d.next_minute()
Out[91]: Delorean(datetime=2014-03-01 05:01:00+00:00, timezone=utc)

In [92]: d.next_day()
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-92-da50f63ce2d4> in <module>()
----> 1 d.next_day()

TypeError: next_day() takes exactly 2 arguments (1 given)

In [93]: d.last_second()
Out[93]: Delorean(datetime=2014-03-01 04:59:59+00:00, timezone=utc)

In [94]: d.last_day()
Out[94]: Delorean(datetime=2014-02-28 05:00:00+00:00, timezone=utc)
@liavkoren
Copy link
Author

Hmm. It looks like my v0.5.0 source has a concrete next_day implementation inside delorean.dates.Delorean, while the https://github.com/myusuf3/delorean/blob/master/delorean/dates.py#L168 omits the concrete implementation. Is the cheese-shop out of date?

@myusuf3
Copy link
Owner

myusuf3 commented Nov 30, 2015

@mlew ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants