Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful errors for failing plugins in ACP #4806

Open
dvz opened this issue Apr 25, 2024 · 0 comments
Open

Graceful errors for failing plugins in ACP #4806

dvz opened this issue Apr 25, 2024 · 0 comments
Labels
s:feedback Status: Feedback. Further information/input needed t:enhancement Type: Enhancement. Contains minor improvements

Comments

@dvz
Copy link
Contributor

dvz commented Apr 25, 2024

Display user-friendly error messages in the ACP's Plugins module when plugins fail to load (including names of the problematic extensions).

While printed PHP errors may indicate specific plugins, on installations/servers with suppressed error output a blank or half-blank page is presented. The Plugins management page is usually most prone to errors, as all plugin files are loaded, including not-yet-activated ones:

require_once MYBB_ROOT."inc/plugins/".$plugin_file;

This may be addressed through a client-side watchdog script included early, and executed on (technical) page load, which inserts error messages according to last-encountered tags in page source (e.g. <!-- plugin-include-before "hello" --> without <!-- plugin-include-after "hello" --> would indicate a failure in the hello plugin).

Future improvements may include:

  • server-side requests to self to check for successful inclusion of plugin files (the client-side watchdog may redirect to such server-side mode to ultimately render the full page correctly)
  • links/advice for "safe mode" plugin management
    Restrict loading plugins files during NO_PLUGINS #4805
@dvz dvz added t:enhancement Type: Enhancement. Contains minor improvements s:feedback Status: Feedback. Further information/input needed labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:feedback Status: Feedback. Further information/input needed t:enhancement Type: Enhancement. Contains minor improvements
Projects
Status: Feedback
Development

No branches or pull requests

1 participant