Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@set_time_limit with php8 #4729

Open
opt-natter opened this issue Jun 15, 2023 · 1 comment · May be fixed by #4730
Open

@set_time_limit with php8 #4729

opt-natter opened this issue Jun 15, 2023 · 1 comment · May be fixed by #4730
Labels
b:1.8 Branch: 1.8.x s:deferred Status: Deferred. Will not be immediately addressed t:enhancement Type: Enhancement. Contains minor improvements

Comments

@opt-natter
Copy link

If the hoster has disabled the set_time_limit function the error supression with the @ operator does no longer work with php 8 https://www.php.net/manual/en/language.operators.errorcontrol.php
Thus the installation ist not possible (Line 11 in install/index.php). Other files are also affected.

Possible Solution?
if(strpos(ini_get('disable_functions'),'set_time_limit')===false)
@set_time_limit(0);

@opt-natter opt-natter linked a pull request Jun 16, 2023 that will close this issue
@dvz dvz added b:1.8 Branch: 1.8.x s:deferred Status: Deferred. Will not be immediately addressed t:task Type: Task. Other activities to perform t:enhancement Type: Enhancement. Contains minor improvements and removed t:task Type: Task. Other activities to perform labels Oct 4, 2023
@dvz
Copy link
Contributor

dvz commented Oct 4, 2023

This should be addressed in 1.9 via b78c90d and

if (function_exists('set_time_limit')) {
@set_time_limit(0);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x s:deferred Status: Deferred. Will not be immediately addressed t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants