Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Formatting & Semantics in Language Files #4553

Open
kjSagee opened this issue Jul 8, 2022 · 1 comment · May be fixed by #4556
Open

Inconsistent Formatting & Semantics in Language Files #4553

kjSagee opened this issue Jul 8, 2022 · 1 comment · May be fixed by #4556

Comments

@kjSagee
Copy link

kjSagee commented Jul 8, 2022

$l['close_thread'] = "<strong>Close Thread</strong>: prevent further posting in this thread.";

$l['close_thread'] = "<b>Close Thread</b>: prevent further posting in this thread.";

Colon should be inside <strong> and <b> tags to match with other lines in those files. Super minor nit-picking, I know.

Additionally across lang files consider changing instances of <b> tags to <strong> (or vice versa). These tags have been made consistent within individual files, but there is a semantic difference between the two. Visually they are the same, but <strong> tags are emphasized semantically as important (ie: to screen readers) whereas <b> tags are solely visual. It's a small change code-wise but has an impact on accessibility. Which pieces of text should just be visually bold for sighted users? Which should be defined as semantically important? The same applies to the difference between <i> and <em> tags as well.

@Eldenroot
Copy link
Contributor

Feel free to open a PR :)

@kjSagee kjSagee linked a pull request Jul 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants