Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACP System Health CHMOD Check Issues #4360

Open
effone opened this issue Apr 20, 2021 · 0 comments · May be fixed by #4361
Open

ACP System Health CHMOD Check Issues #4360

effone opened this issue Apr 20, 2021 · 0 comments · May be fixed by #4361
Assignees
@effone
Labels
b:1.8 Branch: 1.8.x dev-branch Affecting unreleased codebase p:medium Priority: Medium. Issues to be resolved with normal preference t:bug Type: Bug. An issue causing error / flaw / malfunction t:code-quality Type: Code Quality. Improves code without affecting functionality t:optimization Type: Optimization. Improves performance t:regression Type: Regression. Degraded functionality after update

Comments

@effone
Copy link
Member

effone commented Apr 20, 2021 •
edited

  1. Regression: After merging PR Fixes #4338 / #3754 - Relative/absolute path #4342 some paths are displayed relative some are absolute.
    image
    The display effect should be neutralized to produce the results same as before the PR and after.

  2. Bug: $errors was never reset before entering to CHMOD check. If $errors carries any value from previous code it may display wrong notice.

  3. Optimization: Bloated repeated code chunks (around 150 lines) can be dried up and reduced down to just one third (around 50 lines).

  4. The CHMOD Status heading is missing. The first heading is File whereas its listing directories also.
@effone effone added t:bug Type: Bug. An issue causing error / flaw / malfunction b:1.8 Branch: 1.8.x p:medium Priority: Medium. Issues to be resolved with normal preference t:regression Type: Regression. Degraded functionality after update t:optimization Type: Optimization. Improves performance t:code-quality Type: Code Quality. Improves code without affecting functionality labels Apr 20, 2021
@effone effone added this to the 1.8.27 milestone Apr 20, 2021
@effone effone self-assigned this Apr 20, 2021
@dvz dvz added the dev-branch Affecting unreleased codebase label Apr 20, 2021
@effone effone linked a pull request Apr 20, 2021 that will close this issue
Open
lairdshaw added a commit to lairdshaw/mybb that referenced this issue May 13, 2021
@lairdshaw
Rework mybb#4342 - Relative/absolute path
7cbdd06 
Introduce a `mk_path_abs()` function so that the `uploadspath` setting
can be "absolutised" on-demand rather than at the beginning of
processing.

Resolves the first item of mybb#4360 without the need for manipulating the
setting's value in the proposed fix in mybb#4361. If merged, provides the
basis for resolving the conversation[1] in that PR so that it can be
adapted a little and continue to resolve the other items of mybb#4360.

[1] https://github.com/mybb/mybb/pull/4361/files#r617217364
@lairdshaw lairdshaw mentioned this issue May 13, 2021
Merged
@dvz dvz removed this from the 1.8.27 milestone May 17, 2021
dvz pushed a commit that referenced this issue May 17, 2021
@lairdshaw
Rework #4342 - Relative/absolute path (#4370)
9346f90 
Introduce a `mk_path_abs()` function so that the `uploadspath` setting
can be "absolutised" on-demand rather than at the beginning of
processing.

Resolves the first item of #4360 without the need for manipulating the
setting's value in the proposed fix in #4361. If merged, provides the
basis for resolving the conversation[1] in that PR so that it can be
adapted a little and continue to resolve the other items of #4360.

[1] https://github.com/mybb/mybb/pull/4361/files#r617217364
lairdshaw added a commit to lairdshaw/mybb that referenced this issue Oct 11, 2021
@lairdshaw
Rework mybb#4342 - Relative/absolute path (mybb#4370)
e521fb7 
[Rebased for 1.9 by Laird]

Introduce a `mk_path_abs()` function so that the `uploadspath` setting
can be "absolutised" on-demand rather than at the beginning of
processing.

Resolves the first item of mybb#4360 without the need for manipulating the
setting's value in the proposed fix in mybb#4361. If merged, provides the
basis for resolving the conversation[1] in that PR so that it can be
adapted a little and continue to resolve the other items of mybb#4360.

[1] https://github.com/mybb/mybb/pull/4361/files#r617217364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@effone effone

Labels
b:1.8 Branch: 1.8.x dev-branch Affecting unreleased codebase p:medium Priority: Medium. Issues to be resolved with normal preference t:bug Type: Bug. An issue causing error / flaw / malfunction t:code-quality Type: Code Quality. Improves code without affecting functionality t:optimization Type: Optimization. Improves performance t:regression Type: Regression. Degraded functionality after update
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ACP CHMOD Check Fixes effone/mybb
2 participants
@dvz @effone