New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template Conversion to Twig Format #2972
Labels
b:1.9
Branch: 1.9.x
p:high
Priority: High. To resolve with high preference
t:enhancement
Type: Enhancement. Contains minor improvements
Projects
Milestone
Comments
kawaii
added
b:1.9
Branch: 1.9.x
t:enhancement
Type: Enhancement. Contains minor improvements
p:high
Priority: High. To resolve with high preference
labels
Jan 5, 2018
euantorano
pushed a commit
that referenced
this issue
Jan 8, 2018
…2975) * Working on #2972 Template Conversion to Twig Format (warnings.php) Part 1 - User warning log * Coding standards * Working on #2972 Template Conversion to Twig Format (warnings.php) Part 2 - Warning details * Working on #2972 Template Conversion to Twig Format (warnings.php) Part 3 - Warning a user
euantorano
pushed a commit
that referenced
this issue
Jan 14, 2018
euantorano
pushed a commit
that referenced
this issue
Jan 14, 2018
…2984) * Working on #2972 Template Conversion to Twig Format (calendar.php) Part 1 - Adding an event * Working on #2972 Template Conversion to Twig Format (calendar.php) Part 2 - Editing an event * Working on #2972 Template Conversion to Twig Format (calendar.php) Part 3 - Moving event * Working on #2972 Template Conversion to Twig Format (calendar.php) Part 4 - Viewing an event * Working on #2972 Template Conversion to Twig Format (calendar.php) Part 5 - Day view * Working on #2972 Template Conversion to Twig Format (calendar.php) Part 6 - Week view * Working on #2972 Template Conversion to Twig Format (calendar.php) Part 7 - Calendar * Moved gobutton to inline * Code updates -Added selected and checked HTML to templates -Move day select options to array * More code updates - Moved month select options to array - Split bottom calendar jump/month jump into seperate Twig file - Converted user stars to Twig
Are marked as done. Is someone working on forumbit templates? |
This was referenced Jan 18, 2018
This was referenced Jan 24, 2018
euantorano
pushed a commit
that referenced
this issue
Feb 3, 2018
euantorano
pushed a commit
that referenced
this issue
Feb 3, 2018
) * Working on #2972 Template Conversion to Twig Format (contact.php) * Indented template
This was referenced Feb 4, 2018
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
…s) (#3142) * Converted usercp usergroups * Dropped alt_trow() * Remove escaping * Changed loop condition
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
* Fixes #3034 usercp2.php removal (#3093) * THIS_SCRIPT Fallback added. Moved from ./global.php * Revert "THIS_SCRIPT Fallback added." This reverts commit 81fecc7. * Removal of usercp2 Removed traces of usercp2 from wol functions * Removed traces of usercp2 Updated Unsubscription Information links. * Removal of usercp2 CSS attachment & links updated. * Merged usercp2 codes Combined usercp & usercp2 codes. Maintained usercp condition style. * Delete usercp2.php Codes combined in usercp. * Hook names retained 1. Hook names reverted to earlier for backward compatibility 2. $plugins->run_hooks("usercp2_start"); Dropped. 3. Comments added to hooks for reference. * Removed ALLOWABLE_PAGE As suggested ... * Added back "ALLOWABLE_PAGE" .... as confirmed. * Converted usercp_addsubscription_thread * usercp2 -> usercp
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
…3259) * Converted modcp finduser * Removed redundant condition
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
* Converted xmlhttp * Fixed indenting
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
…3252) * Converted smilieinsert * Unlocked smilie inclusion * Fixed indent, moved HTML from php to twig * Minor fixes
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
* Converted footer * Added missing post_code_string * Fixed indent
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
…3242) * Converted usercp_avatar * Fixed indenting and code style * Fixed bburl -> bbname
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
* Converted mycodes * Deleted old parser/video.twig template * Restored onclick and extraclass for smilie template * Moved HTML from php to twig
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
…3243) * Converted usercp options * Converted themeselector and lang fixes to templates * Fixes indent and minor syntax change
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
) * Working on #2972 Template Conversion to Twig Format (private.php) Part 1 - PM searching * Working on #2972 Template Conversion to Twig Format (private.php) Part 2 - Sending a PM * Working on #2972 Template Conversion to Twig Format (private.php) Part 3 - Reading a PM * Working on #2972 Template Conversion to Twig Format (private.php) Part 4 - PM tracking * Working on #2972 Template Conversion to Twig Format (private.php) Part 5 - Managing PM folders * Working on #2972 Template Conversion to Twig Format (private.php) Part 6 - Exporting PMs * Working on #2972 Template Conversion to Twig Format (private.php) Part 7 - PM folders * Fixed formatting issue
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
…3256) * Converted miscellaneous templates * Added php_warnings * Fixed indenting * Fixed indenting and changed & to &
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
* Working on #2972 Template Conversion to Twig Format (misc.php) Part 1 - Forum Rules, Help Docs, Buddy List and Who Posted * Working on #2972 Template Conversion to Twig Format (misc.php) Part 2 - Smilies, IM center and Syndication * Working on #2972 Template Conversion to Twig Format (misc.php) Part 3 - Smilie Pop-up * Removed IM center
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
* Converted forumbit * Fixed issue with unapproved posts and threads being shown even if there weren't any
euantorano
pushed a commit
that referenced
this issue
Jun 2, 2019
(cherry picked from commit afa523f)
How to overing template for new theme? |
Hi,
The new theme system isn’t implemented yet that would allow this. Basically, new themes will add new old paths to the Twig loader which will be tried first.
… On 21 Jun 2019, at 14:58, Denys N ***@***.***> wrote:
How to overing template for new theme?
Thank you!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
that's good. When can I test? |
Hi,
We’ll open a new Pull Request when we have something to show for it. At the minute my focus is on rebasing the 1.9 branch so that it contains all of the latest changes from 1.8.
… On 22 Jun 2019, at 08:29, Denys N ***@***.***> wrote:
that's good. When can I test?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Closed
Any Progress? |
Now that 1.8.23 is released, 1.9 is being rebase upon that release. This should be finished soon, then 1.9 will be touched up to catch any remaining templates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
b:1.9
Branch: 1.9.x
p:high
Priority: High. To resolve with high preference
t:enhancement
Type: Enhancement. Contains minor improvements
This issue is to track the progress of which templates have been converted to the new format for the Twig engine. Please reference this issue in your relevant PRs.
The conversion is over. _nav templates will not be converted until all usercp and modcp PRs are merged, and they will be converted within the final effort to clean up all the files.
The text was updated successfully, but these errors were encountered: