Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All interfaces have optional keys #37

Open
dino-rodriguez opened this issue Jul 5, 2022 · 0 comments
Open

All interfaces have optional keys #37

dino-rodriguez opened this issue Jul 5, 2022 · 0 comments

Comments

@dino-rodriguez
Copy link

dino-rodriguez commented Jul 5, 2022

It seems like all the response interfaces have optional keys (along with some being nullable).

Do these both need to be the case, or is specifying the ones as nullable sufficient? It also seems like these are aggressively nullable, so I'm wondering if all those null scenarios are possible.

It seems a bit cumbersome to have to check for the existence of every key in typescript if it's not nullable.

(I know I can use Required to enforce non-optional, but I'm still wondering if there's something worth looking at here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant