site.upload() should raise exception for warnings #211
Labels
Comments
|
I thought it already did that. Will check. |
marcfrederick
added a commit
that referenced
this issue
Feb 17, 2024
Raises an error when ignore=False and the MediaWiki response contains the `upload.warnings.exists` key. Previously, this warning was logged, but the call to `Site.upload` succeeded. This could be easily missed by users, especially when they haven't configured the log level.
marcfrederick
added a commit
that referenced
this issue
Feb 17, 2024
Raises an error when ignore=False and the MediaWiki response contains the `upload.warnings.exists` key. Previously, this warning was logged, but the call to `Site.upload` succeeded. This could be easily missed by users, especially when they haven't configured the log level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you call
wiki.upload()with an existing filename, MediaWiki returns a warning and does not update the file. Since mwclient swallows these warnings, I just spent a lot of time debugging my program before I figured out what was going on. These warnings should probably be raised as errors instead of ignored.The text was updated successfully, but these errors were encountered: