Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename reqs to something more intuitive #197

Open
danmichaelo opened this issue Sep 2, 2018 · 2 comments
Open

Rename reqs to something more intuitive #197

danmichaelo opened this issue Sep 2, 2018 · 2 comments
Milestone
1.0.0

Comments

@danmichaelo
Copy link
Member

The option was introduced in #105 and renamed in #119, but the name reqs is not very intuitive, so I suggest deprecating reqs in favour of something better (connection_kwargs?). Suggestions are welcome.
@danmichaelo danmichaelo mentioned this issue Sep 2, 2018
Closed
@waldyrious
Copy link
Member

/cc-ing @lgonzalezsa from #196

@danmichaelo danmichaelo added this to the 1.0.0 milestone Jan 23, 2019
@mitar
Copy link
Contributor

mitar commented Feb 11, 2022

Maybe connection_options?

@marcfrederick marcfrederick modified the milestones: 1.0.0, 0.9.1 Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
4 participants
@danmichaelo @waldyrious @mitar @marcfrederick