Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail sooner if the endpoint function doesn't return a string #8

Open
mmcc opened this issue May 6, 2019 · 1 comment
Open

Fail sooner if the endpoint function doesn't return a string #8

mmcc opened this issue May 6, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@mmcc
Copy link
Contributor

mmcc commented May 6, 2019

Currently if someone passes a fetching function as the endpoint option and that function fails to return a URL, UpChunk will merrily continue on and try to upload. We should fail faster with a helpful error message.
@mmcc mmcc added the bug Something isn't working label May 28, 2019
@aminamos
Copy link
Contributor

@mmcc is this still an issue? Would this line catch it?

upchunk/src/upchunk.ts

Line 140 in 638eb15

(typeof this.endpoint !== 'function' && typeof this.endpoint !== 'string')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmcc @aminamos